pgsql: Remove the correct pgstat file on DROP DATABASE

Remove the correct pgstat file on DROP DATABASE

We were unlinking the permanent file, not the non-permanent one. But
since the stat collector already unlinks all permanent files on startup,
there was nothing for it to unlink. The non-permanent file remained in
place, and was copied to the permanent directory on shutdown, so in
effect no file was ever dropped.

Backpatch to 9.3, where the issue was introduced by commit 187492b6c2e8.
Before that, there were no per-database files and thus no file to drop
on DROP DATABASE.

Per report from Thom Brown.

Author: Tomáš Vondra

Branch
------
REL9_3_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/13ea43ab83871a8bed5b9cdf7ec18c62bf63df4f

Modified Files
--------------
src/backend/postmaster/pgstat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)