pgsql: Remove dependency on database encoding in citext regression test

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Remove dependency on database encoding in citext regression test
Date: 2014-02-27 19:58:54
Message-ID: E1WJ76c-000519-Ey@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove dependency on database encoding in citext regression test.

Testing convert_to(..., 'ISO-8859-1') fails if there isn't a conversion
function available from the database encoding to ISO-8859-1. This has
been broken since day one, but the breakage was hidden by
pg_do_encoding_conversion's failure to complain, up till commit
49c817eab78c6f0ce8c3bf46766b73d6cf3190b7.

Since the data being converted in this test is plain ASCII, no actual
conversion need happen (and if it did, it would prove little about citext
anyway). So that we still have some code coverage of the convert() family
of functions, let's switch to using convert_from, with SQL_ASCII as the
specified source encoding. Per buildfarm.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/1161d895d826950cbb736e5872935f3f53cc2e27

Modified Files
--------------
contrib/citext/expected/citext.out | 2 +-
contrib/citext/expected/citext_1.out | 2 +-
contrib/citext/sql/citext.sql | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2014-02-27 21:57:25 pgsql: Allow BASE_BACKUP to be throttled
Previous Message Andres Freund 2014-02-27 14:47:45 Re: pgsql: Fix WAL replay of locking an updated tuple