pgsql: Minor pg_dump improvements

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Minor pg_dump improvements
Date: 2014-02-09 02:29:25
Message-ID: E1WCK97-00074K-0p@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Minor pg_dump improvements

Improve pg_dump by checking results on various fgetc() calls which
previously were unchecked, ditto for ftello. Also clean up a couple
of very minor memory leaks by waiting to allocate structures until
after the initial check(s).

Issues spotted by Coverity.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/cfa1b4a711dd03f824a9c3ab50911e61419d1eeb

Modified Files
--------------
src/bin/pg_dump/pg_backup_archiver.c | 27 +++++++++++++++++++++------
src/bin/pg_dump/pg_backup_custom.c | 5 ++++-
src/bin/pg_dump/pg_dump.c | 8 ++++++--
3 files changed, 31 insertions(+), 9 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Magnus Hagander 2014-02-09 11:19:00 pgsql: Avoid printing uninitialized filename variable in verbose mode
Previous Message Peter Eisentraut 2014-02-09 02:23:03 pgsql: Mark some more variables as static or include the appropriate he