pgsql: Fix some more bugs in signal handlers and process shutdown logic

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix some more bugs in signal handlers and process shutdown logic
Date: 2014-02-01 21:22:01
Message-ID: E1W9i0n-0002yz-48@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix some more bugs in signal handlers and process shutdown logic.

WalSndKill was doing things exactly backwards: it should first clear
MyWalSnd (to stop signal handlers from touching MyWalSnd->latch),
then disown the latch, and only then mark the WalSnd struct unused by
clearing its pid field.

Also, WalRcvSigUsr1Handler and worker_spi_sighup failed to preserve
errno, which is surely a requirement for any signal handler.

Per discussion of recent buildfarm failures. Back-patch as far
as the relevant code exists.

Branch
------
REL9_3_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/6f1a4077310e97fe32379263918a31b95f85e2ed

Modified Files
--------------
contrib/worker_spi/worker_spi.c | 6 +++++-
src/backend/replication/walreceiver.c | 4 ++++
src/backend/replication/walsender.c | 18 ++++++++++++------
3 files changed, 21 insertions(+), 7 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2014-02-01 21:27:01 pgsql: fix whitespace
Previous Message Andrew Dunstan 2014-02-01 21:15:24 pgsql: Don't use deprecated dllwrap on Cygwin.