pgsql: Split ECPGdo() in constituent parts

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Split ECPGdo() in constituent parts
Date: 2014-01-16 19:52:26
Message-ID: E1W3szK-0000oV-KX@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Split ECPGdo() in constituent parts

This splits ECPGdo() into ecpg_prologue(), ecpg_do() and
ecpg_epilogue(), and renames free_params() into ecpg_free_params() and
exports it. This makes it possible for future code to use these
routines for their own purposes.

There is no user-visible functionality change here, only code
reorganization.

Zoltán Böszörményi

Reviewed by Antonin Houska. Larger, older versions of this patch were
reviewed by Noah Misch and Michael Meskes.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/3291301385ee5e9ca38d70a68b93ce31cc2674ac

Modified Files
--------------
src/interfaces/ecpg/ecpglib/execute.c | 228 ++++++++++++--------
src/interfaces/ecpg/ecpglib/extern.h | 10 +
.../test/expected/compat_informix-rnull.stderr | 34 +--
.../test/expected/compat_informix-sqlda.stderr | 4 +-
.../expected/compat_informix-test_informix.stderr | 8 +-
.../expected/compat_informix-test_informix2.stderr | 6 +-
.../ecpg/test/expected/pgtypeslib-dt_test.stderr | 6 +-
.../ecpg/test/expected/pgtypeslib-nan_test.stderr | 28 +--
.../ecpg/test/expected/pgtypeslib-num_test.stderr | 2 +-
.../ecpg/test/expected/preproc-autoprep.stderr | 8 +-
.../ecpg/test/expected/preproc-type.stderr | 2 +-
src/interfaces/ecpg/test/expected/sql-array.stderr | 14 +-
.../ecpg/test/expected/sql-binary.stderr | 8 +-
.../ecpg/test/expected/sql-code100.stderr | 20 +-
src/interfaces/ecpg/test/expected/sql-desc.stderr | 22 +-
.../ecpg/test/expected/sql-execute.stderr | 6 +-
src/interfaces/ecpg/test/expected/sql-fetch.stderr | 2 +-
.../ecpg/test/expected/sql-indicators.stderr | 6 +-
.../ecpg/test/expected/sql-oldexec.stderr | 4 +-
src/interfaces/ecpg/test/expected/sql-sqlda.stderr | 4 +-
20 files changed, 246 insertions(+), 176 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2014-01-16 20:29:48 pgsql: Add display of oprcode (the underlying function's name) to psql'
Previous Message Heikki Linnakangas 2014-01-16 10:01:16 pgsql: Suppress Coverity complaints in readfuncs.c.