From: | Kevin Grittner <kgrittn(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Fix pg_dumpall to work for databases flagged as read-only. |
Date: | 2013-11-30 20:04:13 |
Message-ID: | E1Vmqlx-0000lt-1Q@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix pg_dumpall to work for databases flagged as read-only.
pg_dumpall's charter is to be able to recreate a database cluster's
contents in a virgin installation, but it was failing to honor that
contract if the cluster had any ALTER DATABASE SET
default_transaction_read_only settings. By including a SET command
for the connection for each connection opened by pg_dumpall output,
errors are avoided and the source cluster is successfully
recreated.
There was discussion of whether to also set this for the connection
applying pg_dump output, but it was felt that it was both less
appropriate in that context, and far easier to work around.
Backpatch to all supported branches.
Branch
------
REL9_2_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/27b33245a5f505794a0e8dd4cdb9342f8cf2cc0a
Modified Files
--------------
src/bin/pg_dump/pg_dumpall.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2013-11-30 21:50:41 | pgsql: pg_upgrade: Handle default_transaction_read_only settings |
Previous Message | Kevin Grittner | 2013-11-30 20:04:12 | pgsql: Fix pg_dumpall to work for databases flagged as read-only. |