pgsql: Fix relfilenodemap.c's handling of cache invalidations.

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix relfilenodemap.c's handling of cache invalidations.
Date: 2013-11-13 15:59:16
Message-ID: E1Vgcqa-0005Ou-Mz@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix relfilenodemap.c's handling of cache invalidations.

The old code entered a new hash table entry first, then scanned
pg_class to determine what value to fill in, and then populated the
entry. This fails to work properly if a cache invalidation happens
as a result of opening pg_class. Repair.

Along the way, get rid of the idea of blowing away the entire hash
table as a method of processing invalidations. Instead, just delete
all the entries one by one. This is probably not quite as cheap but
it's simpler, and shouldn't happen often.

Andres Freund

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/c46c803f8ad4ba80472b280703983ecf8021099e

Modified Files
--------------
src/backend/utils/cache/relfilenodemap.c | 189 ++++++++++++++++--------------
1 file changed, 100 insertions(+), 89 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2013-11-13 18:00:33 pgsql: Fix isolation check for MSVC to handle recent changes.
Previous Message Bruce Momjian 2013-11-13 15:14:45 pgsql: docs: clarify MVCC introduction to allow for per-statement snap