pgsql: Use appendStringInfoString instead of appendStringInfo where pos

Use appendStringInfoString instead of appendStringInfo where possible.

This shaves a few cycles, and generally seems like good programming
practice.

David Rowley

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/cacbdd78106526d7c4f11f90b538f96ba8696fb0

Modified Files
--------------
contrib/cube/cube.c | 6 +-
contrib/dblink/dblink.c | 28 ++--
contrib/pg_trgm/trgm_regexp.c | 62 ++++-----
contrib/postgres_fdw/deparse.c | 10 +-
contrib/postgres_fdw/postgres_fdw.c | 6 +-
contrib/tablefunc/tablefunc.c | 2 +-
src/backend/access/rmgrdesc/clogdesc.c | 2 +-
src/backend/access/rmgrdesc/dbasedesc.c | 2 +-
src/backend/access/rmgrdesc/gindesc.c | 16 +--
src/backend/access/rmgrdesc/gistdesc.c | 4 +-
src/backend/access/rmgrdesc/heapdesc.c | 34 ++---
src/backend/access/rmgrdesc/mxactdesc.c | 2 +-
src/backend/access/rmgrdesc/nbtdesc.c | 10 +-
src/backend/access/rmgrdesc/relmapdesc.c | 2 +-
src/backend/access/rmgrdesc/seqdesc.c | 4 +-
src/backend/access/rmgrdesc/smgrdesc.c | 2 +-
src/backend/access/rmgrdesc/spgdesc.c | 2 +-
src/backend/access/rmgrdesc/standbydesc.c | 8 +-
src/backend/access/rmgrdesc/tblspcdesc.c | 2 +-
src/backend/access/rmgrdesc/xactdesc.c | 28 ++--
src/backend/access/rmgrdesc/xlogdesc.c | 6 +-
src/backend/access/transam/xlog.c | 4 +-
src/backend/catalog/objectaddress.c | 123 ++++++++---------
src/backend/commands/explain.c | 4 +-
src/backend/commands/tsearchcmds.c | 2 +-
src/backend/nodes/outfuncs.c | 130 +++++++++---------
src/backend/tcop/postgres.c | 2 +-
src/backend/utils/adt/regproc.c | 4 +-
src/backend/utils/adt/ri_triggers.c | 12 +-
src/backend/utils/adt/ruleutils.c | 214 ++++++++++++++---------------
src/backend/utils/adt/xml.c | 66 +++++----
src/backend/utils/fmgr/dfmgr.c | 2 +-
src/backend/utils/misc/guc.c | 2 +-
33 files changed, 399 insertions(+), 404 deletions(-)