pgsql: Work around NetBSD shell issue in pg_upgrade test script.

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Work around NetBSD shell issue in pg_upgrade test script.
Date: 2013-10-28 15:50:51
Message-ID: E1Vap5f-0003tc-Ov@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Work around NetBSD shell issue in pg_upgrade test script.

The NetBSD shell apparently returns non-zero from an unset command if
the variable is already unset. This matters when, as in pg_upgrade's
test.sh, we are working under 'set -e'. To protect against this, we
first set the PG variables to an empty string before unsetting them
completely.

Error found on buildfarm member coypu, solution from Rémi Zara.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/c737a2e5641a324d3987750b73928c481a5254a0

Modified Files
--------------
contrib/pg_upgrade/test.sh | 20 ++++++++++++--------
1 file changed, 12 insertions(+), 8 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2013-10-28 15:52:11 pgsql: Work around NetBSD shell issue in pg_upgrade test script.
Previous Message Tom Lane 2013-10-28 14:30:15 pgsql: Improve documentation about usage of FDW validator functions.