| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Reset the binary heap in MergeAppend rescans. |
| Date: | 2013-08-30 23:16:11 |
| Message-ID: | E1VFXvH-0002Gn-10@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Reset the binary heap in MergeAppend rescans.
Failing to do so can cause queries to return wrong data, error out or crash.
This requires adding a new binaryheap_reset() method to binaryheap.c,
but that probably should have been there anyway.
Per bug #8410 from Terje Elde. Diagnosis and patch by Andres Freund.
Branch
------
REL9_3_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/16e8e36cebba8909ec01ca259f32e8dd40090657
Modified Files
--------------
src/backend/executor/nodeMergeAppend.c | 1 +
src/backend/lib/binaryheap.c | 20 +++++++++++++++++---
src/include/lib/binaryheap.h | 1 +
3 files changed, 19 insertions(+), 3 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2013-08-30 23:28:02 | pgsql: Add test case for bug #8410. |
| Previous Message | Tom Lane | 2013-08-30 23:16:10 | pgsql: Reset the binary heap in MergeAppend rescans. |