pgsql: Properly dump dropped foreign table cols in binary-upgrade mode.

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Properly dump dropped foreign table cols in binary-upgrade mode.
Date: 2013-06-25 17:47:36
Message-ID: E1UrXL6-0004kT-ML@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Properly dump dropped foreign table cols in binary-upgrade mode.

In binary upgrade mode, we need to recreate and then drop dropped
columns so that all the columns get the right attribute number. This is
true for foreign tables as well as for native tables. For foreign
tables we have been getting the first part right but not the second,
leading to bogus columns in the upgraded database. Fix this all the way
back to 9.1, where foreign tables were introduced.

Branch
------
REL9_3_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/a20d7c3bc3517e0c390a08d4f589fded953c9710

Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2013-06-25 17:47:47 pgsql: Properly dump dropped foreign table cols in binary-upgrade mode.
Previous Message Andrew Dunstan 2013-06-25 17:47:27 pgsql: Properly dump dropped foreign table cols in binary-upgrade mode.