pgsql: Put analyze_keyword back in explain_option_name production.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Put analyze_keyword back in explain_option_name production.
Date: 2013-06-05 17:33:59
Message-ID: E1UkHax-0003yM-J9@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Put analyze_keyword back in explain_option_name production.

In commit 2c92edad48796119c83d7dbe6c33425d1924626d, I broke "EXPLAIN
(ANALYZE)" syntax, because I mistakenly thought that ANALYZE/ANALYSE were
only partially reserved and thus would be included in NonReservedWord;
but actually they're fully reserved so they still need to be called out
here.

A nicer solution would be to demote these words to type_func_name_keyword
status (they can't be less than that because of "VACUUM [ANALYZE] ColId").
While that works fine so far as the core grammar is concerned, it breaks
ECPG's grammar for reasons I don't have time to isolate at the moment.
So do this for the time being.

Per report from Kevin Grittner. Back-patch to 9.0, like the previous
commit.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/3f783c882712db5a5e0056f271ff765edeb2571a

Modified Files
--------------
src/backend/parser/gram.y | 1 +
1 file changed, 1 insertion(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2013-06-06 02:10:17 pgsql: Update SQL features list
Previous Message Peter Eisentraut 2013-06-05 03:15:08 pgsql: doc: Add IDs to link targets used by phpPgAdmin