From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Add semicolons to eval'd strings to hide a minor Perl behavioral |
Date: | 2013-06-03 18:20:08 |
Message-ID: | E1UjZMW-0002kk-Qq@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Add semicolons to eval'd strings to hide a minor Perl behavioral change.
"eval q{foo}" used to complain that the error was on line 2 of the eval'd
string, because eval internally tacked on "\n;" so that the end of the
erroneous command was indeed on line 2. But as of Perl 5.18 it more
sanely says that the error is on line 1. To avoid Perl-version-dependent
regression test results, use "eval q{foo;}" instead in the two places
where this matters. Per buildfarm.
Since people might try to use newer Perl versions with older PG releases,
back-patch as far as 9.0 where these test cases were added.
Branch
------
REL9_2_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/cc510d97afe63cacb3129d4bd19b14118cada6bb
Modified Files
--------------
src/pl/plperl/expected/plperl.out | 4 ++--
src/pl/plperl/expected/plperl_init.out | 10 +++++-----
src/pl/plperl/sql/plperl.sql | 2 +-
src/pl/plperl/sql/plperl_init.sql | 2 +-
4 files changed, 9 insertions(+), 9 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2013-06-04 15:53:56 | pgsql: Fix off-by-one in pg_xlogdump -r option. |
Previous Message | Heikki Linnakangas | 2013-06-03 14:22:48 | pgsql: Put back allow_system_table_mods check in heap_create(). |