pgsql: Code review of recycling WAL segments in a restartpoint.

From: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Code review of recycling WAL segments in a restartpoint.
Date: 2013-06-03 07:08:54
Message-ID: E1UjOsw-0000wt-MW@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Code review of recycling WAL segments in a restartpoint.

Seems cleaner to get the currently-replayed TLI in the same call to
GetXLogReplayRecPtr that we get the WAL position. Make it more clear in the
comment what the code does when recovery has already ended
(RecoveryInProgress() will set ThisTimeLineID in that case). Finally, make
resetting ThisTimeLineID afterwards more explicit.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/e1e2bb34f1237cbec396bcaa795f0fa955af0e72

Modified Files
--------------
src/backend/access/transam/xlog.c | 30 +++++++++++++++---------------
1 file changed, 15 insertions(+), 15 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Stephen Frost 2013-06-03 12:42:35 pgsql: Additional spelling corrections
Previous Message Tom Lane 2013-06-03 00:10:04 pgsql: Allow type_func_name_keywords in some places where they weren't