pgsql: Guard against input_rows == 0 in estimate_num_groups().

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Guard against input_rows == 0 in estimate_num_groups().
Date: 2013-05-10 21:16:30
Message-ID: E1Uaug2-0007Fx-Pj@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Guard against input_rows == 0 in estimate_num_groups().

This case doesn't normally happen, because the planner usually clamps
all row estimates to at least one row; but I found that it can arise
when dealing with relations excluded by constraints. Without a defense,
estimate_num_groups() can return zero, which leads to divisions by zero
inside the planner as well as assertion failures in the executor.

An alternative fix would be to change set_dummy_rel_pathlist() to make
the size estimate for a dummy relation 1 row instead of 0, but that seemed
pretty ugly; and probably someday we'll want to drop the convention that
the minimum rowcount estimate is 1 row.

Back-patch to 8.4, as the problem can be demonstrated that far back.

Branch
------
REL9_0_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/dbd68df9b636d4b36469dab7281a2e7d38863570

Modified Files
--------------
src/backend/utils/adt/selfuncs.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2013-05-10 22:17:40 Re: pgsql: pg_upgrade: Remove PGPORT handling from test suite
Previous Message Tom Lane 2013-05-10 17:07:35 pgsql: Fix pgp_pub_decrypt() so it works for secret keys with passwords