From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Disallow unlogged materialized views. |
Date: | 2013-05-06 16:01:43 |
Message-ID: | E1UZNrD-0008Eh-83@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Disallow unlogged materialized views.
The initial implementation of this feature was really unsupportable,
because it's relying on the physical size of an on-disk file to carry the
relation's populated/unpopulated state, which is at least a modularity
violation and could have serious long-term consequences. We could say that
an unlogged matview goes to empty on crash, but not everybody likes that
definition, so let's just remove the feature for 9.3. We can add it back
when we have a less klugy implementation.
I left the grammar and tab-completion support for CREATE UNLOGGED
MATERIALIZED VIEW in place, since it's harmless and allows delivering a
more specific error message about the unsupported feature.
I'm committing this separately to ease identification of what should be
reverted when/if we are able to re-enable the feature.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/3223b25ff737c2bf4a642c0deb7be2b30bfecc6e
Modified Files
--------------
doc/src/sgml/ref/create_materialized_view.sgml | 12 +-----
src/backend/parser/analyze.c | 12 +++++
src/test/regress/expected/matview.out | 57 +-----------------------
src/test/regress/sql/matview.sql | 19 +-------
4 files changed, 16 insertions(+), 84 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2013-05-06 16:01:46 | Re: pgsql: Translation updates |
Previous Message | Tom Lane | 2013-05-06 15:05:21 | Re: pgsql: Translation updates |