pgsql: Minor robustness improvements for isolationtester.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Minor robustness improvements for isolationtester.
Date: 2013-04-03 01:16:09
Message-ID: E1UNCJ7-0007JR-6O@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Minor robustness improvements for isolationtester.

Notice and complain about PQcancel() failures. Also, don't dump core if
an error PGresult doesn't contain severity and message subfields, as it
might not if it was generated by libpq itself. (We have a longstanding
TODO item to improve that, but in the meantime isolationtester had better
cope.)

I tripped across the latter item while investigating a trouble report on
buildfarm member spoonbill. As for the former, there's no evidence that
PQcancel failure is actually involved in spoonbill's problem, but it still
seems like a bad idea to ignore an error return code.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/845d335a90b684dd51e80a6470ebb923a59a1f91

Modified Files
--------------
src/test/isolation/isolationtester.c | 31 ++++++++++++++++++++++---------
1 files changed, 22 insertions(+), 9 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message oonishitk 2013-04-03 07:12:17 pgbulkload - pgbulkload: - Fix bugs of the WRITER = PARALLEL.
Previous Message Tom Lane 2013-04-01 18:29:18 pgsql: Stamp 9.0.13.