pgsql: Fix contrib/postgres_fdw's handling of column defaults.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix contrib/postgres_fdw's handling of column defaults.
Date: 2013-03-12 22:58:22
Message-ID: E1UFY9G-0006eC-1x@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix contrib/postgres_fdw's handling of column defaults.

Adopt the position that only locally-defined defaults matter. Any defaults
defined in the remote database do not affect insertions performed through
a foreign table (unless they are for columns not known to the foreign
table). While it'd arguably be more useful to permit remote defaults to be
used, making that work in a consistent fashion requires far more work than
seems possible for 9.3.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/50c19fc76f05124b80fc4c5d20a359c5dbf017af

Modified Files
--------------
contrib/postgres_fdw/deparse.c | 55 ++---
contrib/postgres_fdw/expected/postgres_fdw.out | 285 ++++++++++++------------
contrib/postgres_fdw/postgres_fdw.c | 43 +++-
contrib/postgres_fdw/postgres_fdw.h | 9 +-
contrib/postgres_fdw/sql/postgres_fdw.sql | 15 +-
5 files changed, 205 insertions(+), 202 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2013-03-12 23:06:58 pgsql: Fix documentation oversight.
Previous Message Tom Lane 2013-03-12 21:37:23 pgsql: Allow default expressions to be attached to columns of foreign t