pgsql: Only quote libpq connection string values that need quoting.

From: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Only quote libpq connection string values that need quoting.
Date: 2013-02-25 17:53:31
Message-ID: E1UA2F1-00089G-3h@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Only quote libpq connection string values that need quoting.

There's no harm in excessive quoting per se, but it makes the strings nicer
to read. The values can get quite unwieldy, when they're first quoted within
within single-quotes when included in the connection string, and then all
the single-quotes are escaped when the connection string is passed as a
shell argument.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/2953cd6d17210935098c803c52c6df5b12a725b9

Modified Files
--------------
src/bin/pg_dump/pg_dumpall.c | 37 +++++++++++++++++++++++++++++++------
1 files changed, 31 insertions(+), 6 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Erik Rijkers 2013-02-25 22:07:27 Re: Materialized views WIP patch
Previous Message Heikki Linnakangas 2013-02-25 17:43:28 pgsql: Add -d/--dbname option to pg_dump.