| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Get rid of postgres_fdw's assumption that remote type OIDs match |
| Date: | 2013-02-22 11:37:28 |
| Message-ID: | E1U8qwS-00061b-IW@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Get rid of postgres_fdw's assumption that remote type OIDs match ours.
The only place we depended on that was in sending numeric type OIDs in
PQexecParams; but we can replace that usage with explicitly casting
each Param symbol in the query string, so that the types are specified
to the remote by name not OID. This makes no immediate difference but
will be essential if we ever hope to support use of non-builtin types.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/5fd386bb31f9a8ed5058093bc3f8937fdde3dbec
Modified Files
--------------
contrib/postgres_fdw/deparse.c | 18 ++++++++++++------
contrib/postgres_fdw/expected/postgres_fdw.out | 12 ++++++------
contrib/postgres_fdw/postgres_fdw.c | 15 ++++++++++++++-
3 files changed, 32 insertions(+), 13 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2013-02-22 12:30:34 | pgsql: Change postgres_fdw to show casts as casts, not underlying funct |
| Previous Message | Heikki Linnakangas | 2013-02-22 11:13:01 | pgsql: Fix thinko in previous commit. |