pgsql: Adjust postgres_fdw's search path handling.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Adjust postgres_fdw's search path handling.
Date: 2013-02-22 11:05:19
Message-ID: E1U8qRL-0005VT-Fq@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Adjust postgres_fdw's search path handling.

Set the remote session's search path to exactly "pg_catalog" at session
start, then schema-qualify only names that aren't in that schema. This
greatly reduces clutter in the generated SQL commands, as seen in the
regression test changes. Per discussion.

Also, rethink use of FirstNormalObjectId as the "built-in object" cutoff
--- FirstBootstrapObjectId is safer, since the former will accept
objects in information_schema for instance.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/6d06049493862f7f6b639035198fc817949723ae

Modified Files
--------------
contrib/postgres_fdw/connection.c | 29 ++++
contrib/postgres_fdw/deparse.c | 101 ++++++++++-----
contrib/postgres_fdw/expected/postgres_fdw.out | 164 ++++++++++++------------
3 files changed, 180 insertions(+), 114 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2013-02-22 11:13:01 pgsql: Fix thinko in previous commit.
Previous Message Heikki Linnakangas 2013-02-22 10:39:27 pgsql: If recovery.conf is created after "pg_ctl stop -m i", do crash r