pgsql: Fix pg_dumpall with database names containing =

From: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix pg_dumpall with database names containing =
Date: 2013-02-20 15:14:40
Message-ID: E1U8BNY-0008Uu-7A@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Fix pg_dumpall with database names containing =

If a database name contained a '=' character, pg_dumpall failed. The problem
was in the way pg_dumpall passes the database name to pg_dump on the
command line. If it contained a '=' character, pg_dump would interpret it
as a libpq connection string instead of a plain database name.

To fix, pass the database name to pg_dump as a connection string,
"dbname=foo", with the database name escaped if necessary.

Back-patch to all supported branches.

Branch
------
REL9_1_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/957bafb2091136161cb7f1a8a56439310c6bd1b2

Modified Files
--------------
src/bin/pg_dump/pg_dumpall.c | 34 +++++++++++++++++++++++++++++++++-
1 files changed, 33 insertions(+), 1 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Kevin Grittner 2013-02-20 15:24:14 Re: Materialized views WIP patch
Previous Message Heikki Linnakangas 2013-02-20 14:37:04 pgsql: Don't pass NULL to fprintf, if a bogus connection string is give

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2013-02-20 15:16:45 Re: [RFC] indirect toast tuple support
Previous Message Jehan-Guillaume de Rorthais 2013-02-20 15:05:00 Re: Unarchived WALs deleted after crash