pgsql: Remove useless picksplit-doesn't-support-secondary-split log spa

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Remove useless picksplit-doesn't-support-secondary-split log spa
Date: 2013-02-10 18:08:27
Message-ID: E1U4bKF-0003Yt-NH@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove useless picksplit-doesn't-support-secondary-split log spam.

This LOG message was put in over five years ago with the evident
expectation that we'd make all GiST opclasses support secondary split
directly. However, no such thing ever happened, and indeed the number of
opclasses supporting it decreased to zero in 9.2. The reason is that
improving on the default implementation isn't that easy --- the
opclass-specific code that did exist, before 9.2, doesn't appear to have
been any improvement over the default.

Hence, remove the message altogether. There's certainly no point in
nagging users about this in released branches, but I doubt that we'll
ever implement complete opclass-specific support anyway.

Branch
------
REL9_0_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/782365a6bdff3ec0162771d0f4111897065ffb7d

Modified Files
--------------
src/backend/access/gist/gistsplit.c | 20 +++++---------------
1 files changed, 5 insertions(+), 15 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2013-02-10 21:22:11 pgsql: Further cleanup of gistsplit.c.
Previous Message Tom Lane 2013-02-10 17:40:27 pgsql: Remove vestigial secondary-split support in gist_box_picksplit()