pgsql: Fix SPI documentation for new handling of ExecutorRun's count pa

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix SPI documentation for new handling of ExecutorRun's count pa
Date: 2013-01-24 23:34:36
Message-ID: E1TyWJY-0007QX-Lq@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix SPI documentation for new handling of ExecutorRun's count parameter.

Since 9.0, the count parameter has only limited the number of tuples
actually returned by the executor. It doesn't affect the behavior of
INSERT/UPDATE/DELETE unless RETURNING is specified, because without
RETURNING, the ModifyTable plan node doesn't return control to execMain.c
for each tuple. And we only check the limit at the top level.

While this behavioral change was unintentional at the time, discussion of
bug #6572 led us to the conclusion that we prefer the new behavior anyway,
and so we should just adjust the docs to match rather than change the code.
Accordingly, do that. Back-patch as far as 9.0 so that the docs match the
code in each branch.

Branch
------
REL9_0_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/6121539aca2c797b8a9a78bb642ed060a9209d8e

Modified Files
--------------
doc/src/sgml/spi.sgml | 47 +++++++++++++++++++++++++-------------
src/backend/executor/execMain.c | 6 +++-
2 files changed, 35 insertions(+), 18 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2013-01-25 02:21:56 pgsql: doc: correct sepgsql doc about permission checking of CASCADE
Previous Message Andrew Dunstan 2013-01-24 21:02:13 pgsql: Use correct output device for Windows prompts.