pgsql: Remove obsolete XLogRecPtr macros

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Remove obsolete XLogRecPtr macros
Date: 2012-12-28 16:23:23
Message-ID: E1TociR-0005NI-DP@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove obsolete XLogRecPtr macros

This gets rid of XLByteLT, XLByteLE, XLByteEQ and XLByteAdvance.
These were useful for brevity when XLogRecPtrs were split in
xlogid/xrecoff; but now that they are simple uint64's, they are just
clutter. The only downside to making this change would be ease of
backporting patches, but that has been negated by other substantive
changes to the involved code anyway. The clarity of simpler expressions
makes the change worthwhile.

Most of the changes are mechanical, but in a couple of places, the patch
author chose to invert the operator sense, making the code flow more
logical (and more in line with preceding comments).

Author: Andres Freund
Eyeballed by Dimitri Fontaine and Alvaro Herrera

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/5ab3af46ddd2f2c2b248f1ffdb688b394d4bb387

Modified Files
--------------
src/backend/access/gin/ginxlog.c | 20 ++--
src/backend/access/gist/gist.c | 14 ++--
src/backend/access/gist/gistget.c | 2 +-
src/backend/access/gist/gistvacuum.c | 2 +-
src/backend/access/gist/gistxlog.c | 4 +-
src/backend/access/heap/heapam.c | 22 ++--
src/backend/access/nbtree/nbtxlog.c | 16 ++--
src/backend/access/spgist/spgxlog.c | 36 ++++----
src/backend/access/transam/clog.c | 2 +-
src/backend/access/transam/slru.c | 2 +-
src/backend/access/transam/timeline.c | 4 +-
src/backend/access/transam/twophase.c | 2 +-
src/backend/access/transam/xlog.c | 144 ++++++++++++++--------------
src/backend/commands/sequence.c | 2 +-
src/backend/replication/syncrep.c | 12 +-
src/backend/replication/walreceiver.c | 12 +-
src/backend/replication/walreceiverfuncs.c | 2 +-
src/backend/replication/walsender.c | 26 +++---
src/bin/pg_basebackup/receivelog.c | 2 +-
src/include/access/xlogdefs.h | 14 ---
20 files changed, 163 insertions(+), 177 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2012-12-29 13:09:00 pgsql: Adjust more backend functions to return OID rather than void.
Previous Message Alvaro Herrera 2012-12-27 21:37:44 pgsql: Assign InvalidXLogRecPtr instead of MemSet(0)