From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Revert patch for taking fewer snapshots. |
Date: | 2012-11-26 20:56:12 |
Message-ID: | E1Td5iu-00051g-Bk@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Revert patch for taking fewer snapshots.
This reverts commit d573e239f03506920938bf0be56c868d9c3416da, "Take fewer
snapshots". While that seemed like a good idea at the time, it caused
execution to use a snapshot that had been acquired before locking any of
the tables mentioned in the query. This created user-visible anomalies
that were not present in any prior release of Postgres, as reported by
Tomas Vondra. While this whole area could do with a redesign (since there
are related cases that have anomalies anyway), it doesn't seem likely that
any future patch would be reasonably back-patchable; and we don't want 9.2
to exhibit a behavior that's subtly unlike either past or future releases.
Hence, revert to prior code while we rethink the problem.
Branch
------
REL9_2_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/786afc1ce53126feecf4d02e96e7455669ccbf5a
Modified Files
--------------
doc/src/sgml/release-9.2.sgml | 7 -------
src/backend/commands/portalcmds.c | 2 +-
src/backend/commands/prepare.c | 2 +-
src/backend/executor/spi.c | 18 +++++++++++-------
src/backend/tcop/postgres.c | 32 +++++++++++---------------------
src/backend/tcop/pquery.c | 15 +++++++--------
src/include/tcop/pquery.h | 2 +-
7 files changed, 32 insertions(+), 46 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2012-11-26 22:36:32 | pgsql: Remove inaccurate "Incrementally Updated Backups" documentation |
Previous Message | Tom Lane | 2012-11-26 17:58:32 | pgsql: Fix SELECT DISTINCT with index-optimized MIN/MAX on inheritance |