pgsql: Fix erroneous choices of segNo variables

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix erroneous choices of segNo variables
Date: 2012-10-31 14:09:52
Message-ID: E1TTYzQ-0007pn-Im@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Fix erroneous choices of segNo variables

Commit dfda6eba (which changed segment numbers to use a single 64 bit
variable instead of log/seg) introduced a couple of bogus choices of
exactly which log segment number variable to use in each case.

This is currently pretty harmless; in one place, the bogus number was
only being used in an error message for a pretty unlikely condition
(failure to fsync a WAL segment file). In the other, it was using a
global variable instead of the local variable; but all callsites were
passing the value of the global variable anyway.

No need to backpatch because that commit is not on earlier branches.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/9b8dd7e8aa19e6145a996cfc881b5617f497632d

Modified Files
--------------
src/backend/access/transam/xlog.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2012-10-31 14:35:32 Re: [COMMITTERS] pgsql: Fix erroneous choices of segNo variables
Previous Message Alvaro Herrera 2012-10-31 13:54:47 pgsql: Fix ALTER EXTENSION / SET SCHEMA

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2012-10-31 14:35:32 Re: [COMMITTERS] pgsql: Fix erroneous choices of segNo variables
Previous Message Pavel Stehule 2012-10-31 14:07:42 Re: NOWAIT doesn't work