pgsql: In pg_dump, dump SEQUENCE SET items in the data not pre-data sec

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: In pg_dump, dump SEQUENCE SET items in the data not pre-data sec
Date: 2012-10-26 16:13:16
Message-ID: E1TRmX6-0005Rb-6v@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

In pg_dump, dump SEQUENCE SET items in the data not pre-data section.

Represent a sequence's current value as a separate TableDataInfo dumpable
object, so that it can be dumped within the data section of the archive
rather than in pre-data. This fixes an undesirable inconsistency between
the meanings of "--data-only" and "--section=data", and also fixes dumping
of sequences that are marked as extension configuration tables, as per a
report from Marko Kreen back in July. The main cost is that we do one more
SQL query per sequence, but that's probably not very meaningful in most
databases.

Back-patch to 9.1, since it has the extension configuration issue even
though not the --section switch.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/5a39114fe7d19280f6477ce1eb0d88beafda13a4

Modified Files
--------------
doc/src/sgml/ref/pg_dump.sgml | 8 +-
src/bin/pg_dump/pg_dump.c | 309 +++++++++++++++++++++--------------------
2 files changed, 165 insertions(+), 152 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2012-10-26 18:20:54 pgsql: Prefer actual constants to pseudo-constants in equivalence class
Previous Message Tom Lane 2012-10-24 20:26:31 pgsql: Tweak genericcostestimate's fudge factor for index size.