From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Code review for 64-bit-large-object patch. |
Date: | 2012-10-08 22:24:45 |
Message-ID: | E1TLLkj-00064Q-Lu@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Code review for 64-bit-large-object patch.
Fix broken-on-bigendian-machines byte-swapping functions, add missed update
of alternate regression expected file, improve error reporting, remove some
unnecessary code, sync testlo64.c with current testlo.c (it seems to have
been cloned from a very old copy of that), assorted cosmetic improvements.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/26fe56481c0f7baa705f0b3265b5a0676f894a94
Modified Files
--------------
src/backend/libpq/be-fsstubs.c | 60 ++++++------------
src/backend/storage/large_object/inv_api.c | 75 +++++++++++++++-------
src/backend/utils/errcodes.txt | 1 -
src/include/catalog/pg_proc.h | 2 +-
src/interfaces/libpq/fe-lobj.c | 87 ++++++++++----------------
src/test/examples/testlo64.c | 75 +++++++---------------
src/test/regress/input/largeobject.source | 2 +-
src/test/regress/output/largeobject.source | 2 +-
src/test/regress/output/largeobject_1.source | 82 ++++++++++++++++++++++++
9 files changed, 215 insertions(+), 171 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2012-10-09 00:37:15 | pgsql: Remove generation of repl_gram.h |
Previous Message | Alvaro Herrera | 2012-10-08 21:33:54 | pgsql: Fix thinko in previous commit |