pgsql: Back-patch fix and test case for bug #7516.

Back-patch fix and test case for bug #7516.

Back-patch commits 9afc6481117d2dd936e752da0424a2b6b05f6459 and
b8fbbcf37f22c5e8361da939ad0fc4be18a34ca9. The first of these is really
a minor code cleanup to save a few cycles, but it turns out to provide
a workaround for the misoptimization problem described in bug #7516.
The second commit adds a regression test case.

Back-patch the fix to all active branches. The test case only works
as far back as 9.0, because it relies on plpgsql which isn't installed
by default before that. (I didn't have success modifying it into an
all-plperl form that still provoked a crash, though this may just reflect
my lack of Perl-fu.)

Branch
------
REL8_4_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/1e234542805401277d33f8b3fa01b7a771bb98c0

Modified Files
--------------
src/pl/plperl/plperl.c | 29 ++++++++++-------------------
1 files changed, 10 insertions(+), 19 deletions(-)