From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Improve reporting of error situations in find_other_exec(). |
Date: | 2012-07-27 23:32:07 |
Message-ID: | E1Suu0t-0004Or-Vw@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Improve reporting of error situations in find_other_exec().
This function suppressed any stderr output from the called program, which
is unnecessary in the normal case and unhelpful in error cases. It also
gave a rather opaque message along the lines of "fgets failure: Success"
in case the called program failed to return anything on stdout. Since
we've seen multiple reports of people not understanding what's wrong when
pg_ctl reports this, improve the message.
Back-patch to all active branches.
Branch
------
REL8_3_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/53bc376d089d29cf34b98d1c72444ada4a7d9450
Modified Files
--------------
src/port/exec.c | 13 +++++++++++--
1 files changed, 11 insertions(+), 2 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2012-07-30 14:16:13 | pgsql: Now that the diskchecker.pl author has updated the download link |
Previous Message | Bruce Momjian | 2012-07-27 01:25:41 | pgsql: Update doc mention of diskchecker.pl to add URL for script; reta |