| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Revisit error message details for JSON input parsing. |
| Date: | 2012-06-13 23:43:58 |
| Message-ID: | E1SexEE-00034E-Sb@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Revisit error message details for JSON input parsing.
Instead of identifying error locations only by line number (which could
be entirely unhelpful with long input lines), provide a fragment of the
input text too, placing this info in a new CONTEXT entry. Make the
error detail messages conform more closely to style guidelines, fix
failure to expose some of them for translation, ensure compiler can
check formats against supplied parameters.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/80edfd76591fdb9beec061de3c05ef4e9d96ce56
Modified Files
--------------
src/backend/utils/adt/json.c | 211 +++++++++++++++++++++++++++---------
src/test/regress/expected/json.out | 99 +++++++++++------
2 files changed, 224 insertions(+), 86 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2012-06-13 23:49:07 | Re: [COMMITTERS] pgsql: Mark JSON error detail messages for translation. |
| Previous Message | Tom Lane | 2012-06-13 22:57:39 | pgsql: Remove release note entry for reverted patch. |