pgsql: Avoid early reuse of btree pages, causing incorrect query result

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Avoid early reuse of btree pages, causing incorrect query result
Date: 2012-06-01 11:39:30
Message-ID: E1SaQCY-0006xx-LT@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Avoid early reuse of btree pages, causing incorrect query results.
When we allowed read-only transactions to skip assigning XIDs
we introduced the possibility that a fully deleted btree page
could be reused. This broke the index link sequence which could
then lead to indexscans silently returning fewer rows than would
have been correct. The actual incidence of silent errors from
this is thought to be very low because of the exact workload
required and locking pre-conditions. Fix is to remove pages only
if index page opaque->btpo.xact precedes RecentGlobalXmin.

Noah Misch, reviewed by Simon Riggs

Branch
------
REL9_1_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/873d1c11ea25f24815861c2e474fc43500d561c8

Modified Files
--------------
src/backend/access/nbtree/README | 8 +++++---
src/backend/access/nbtree/nbtpage.c | 32 ++++++++++----------------------
src/backend/access/nbtree/nbtxlog.c | 6 +++++-
3 files changed, 20 insertions(+), 26 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Simon Riggs 2012-06-01 11:47:56 pgsql: Avoid early reuse of btree pages, causing incorrect query result
Previous Message Simon Riggs 2012-06-01 11:38:12 pgsql: Avoid early reuse of btree pages, causing incorrect query result