From: | Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Fix corner case in cleanup of transactions using SSI. |
Date: | 2012-01-18 16:01:53 |
Message-ID: | E1RnXxR-00039J-9Y@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix corner case in cleanup of transactions using SSI.
When the only remaining active transactions are READ ONLY, we do a "partial
cleanup" of committed transactions because certain types of conflicts
aren't possible anymore. For committed r/w transactions, we release the
SIREAD locks but keep the SERIALIZABLEXACT. However, for committed r/o
transactions, we can go further and release the SERIALIZABLEXACT too. The
problem was with the latter case: we were returning the SERIALIZABLEXACT to
the free list without removing it from the finished list.
The only real change in the patch is the SHMQueueDelete line, but I also
reworked some of the surrounding code to make it obvious that r/o and r/w
transactions are handled differently -- the existing code felt a bit too
clever.
Dan Ports
Branch
------
REL9_1_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/02f377dbe50074a7016f4a476a8d15d294cd0874
Modified Files
--------------
src/backend/storage/lmgr/predicate.c | 26 +++++++++++++++++++++++---
1 files changed, 23 insertions(+), 3 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2012-01-18 19:03:24 | pgsql: PL/Python: Update example |
Previous Message | Magnus Hagander | 2012-01-18 09:35:40 | pgsql: Show psql timing output for failed queries as well as successful |