pgsql: Fix one-byte buffer overrun in contrib/test_parser.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix one-byte buffer overrun in contrib/test_parser.
Date: 2012-01-10 00:59:01
Message-ID: E1RkQ3J-0005bs-AM@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix one-byte buffer overrun in contrib/test_parser.

The original coding examined the next character before verifying that
there *is* a next character. In the worst case with the input buffer
right up against the end of memory, this would result in a segfault.

Problem spotted by Paul Guyot; this commit extends his patch to fix an
additional case. In addition, make the code a tad more readable by not
overloading the usage of *tlen.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/89b3c6cc8b560f7f46a6a25b270aed5330c09a0e

Modified Files
--------------
contrib/test_parser/test_parser.c | 19 ++++++++++---------
1 files changed, 10 insertions(+), 9 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message User Fxjr 2012-01-10 03:14:13 npgsql - Npgsql2: Fixed tabulation.
Previous Message Peter Eisentraut 2012-01-09 19:14:11 pgsql: Add compatibility note about grant options on GRANT reference pa