pgsql: Work around perl bug in SvPVutf8().

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Work around perl bug in SvPVutf8().
Date: 2012-01-05 17:05:39
Message-ID: E1Riql1-0006yO-Vr@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Work around perl bug in SvPVutf8().

Certain things like typeglobs or readonly things like $^V cause
perl's SvPVutf8() to die nastily and crash the backend. To avoid
that bug we make a copy of the object, which will subsequently be
garbage collected.

Back patched to 9.1 where we first started using SvPVutf8().

Per -hackers discussion. Original problem reported by David Wheeler.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/2abefd9a92f3c02ad4f6030ac1578bbf314db368

Modified Files
--------------
src/pl/plperl/plperl_helpers.h | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2012-01-05 17:52:23 pgsql: Improve ALTER DOMAIN / DROP CONSTRAINT with nonexistent constrai
Previous Message Andrew Dunstan 2012-01-05 17:05:24 pgsql: Work around perl bug in SvPVutf8().

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2012-01-05 17:08:09 Re: PL/Perl Does not Like vstrings
Previous Message Kevin Grittner 2012-01-05 16:41:59 Re: Client Messages