pgsql: Code review for range-types catalog entries.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Code review for range-types catalog entries.
Date: 2011-11-16 23:21:58
Message-ID: E1RQonm-0001kk-Ot@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Code review for range-types catalog entries.

Fix assorted infelicities, such as dependency on OIDs that aren't
hardwired, as well as outright misdeclaration of daterange_canonical(),
which resulted in crashes if you invoked it directly. Add some more
regression tests to try to catch similar mistakes in future.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/4509033a00df5f49c42a21772d8d617efe83e549

Modified Files
--------------
src/include/catalog/catversion.h | 2 +-
src/include/catalog/indexing.h | 2 +-
src/include/catalog/pg_opclass.h | 23 +++++++++-----
src/include/catalog/pg_operator.h | 39 +++++++++++-----------
src/include/catalog/pg_proc.h | 50 ++++++++++++++--------------
src/include/catalog/pg_range.h | 14 ++++----
src/include/catalog/pg_type.h | 5 +--
src/test/regress/expected/rangetypes.out | 26 +++++++-------
src/test/regress/expected/type_sanity.out | 50 ++++++++++++++++++++++++++++-
src/test/regress/sql/rangetypes.sql | 12 +++---
src/test/regress/sql/type_sanity.sql | 41 +++++++++++++++++++++++-
11 files changed, 179 insertions(+), 85 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Meskes 2011-11-17 13:51:02 pgsql: Applied Zoltan's patch to correctly align interval and timestamp
Previous Message User Hinoue 2011-11-16 14:22:17 psqlodbc - psqlodbc: Fix memory leaks in case memory overflow.