| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Fix bugs in the COPY heap-insert batching patch. |
| Date: | 2011-11-09 19:28:33 |
| Message-ID: | E1RODp3-0001lm-Dg@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix bugs in the COPY heap-insert batching patch.
Forgot to call RestoreBkpBlocks() in the redo-function, as pointed out by
Simon Riggs. In redo of a regular heap insert, it's taken care of in
heap_redo(), but this new record type uses the heap2 RM, and heap2_redo()
does not take care of that for you.
Also, failed to reset the vmbuffer and all_visibile_cleared local variables
after switching to a new buffer.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/f81648cb1ee5ce8d2e479a17db512046012c77e7
Modified Files
--------------
src/backend/access/heap/heapam.c | 13 ++++++++++---
1 files changed, 10 insertions(+), 3 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2011-11-09 19:46:29 | pgsql: Only install the extension files for the current Python major ve |
| Previous Message | Peter Eisentraut | 2011-11-09 18:58:29 | pgsql: Clean gettext-files file in clean target |