pgsql: Fix assorted bugs in contrib/unaccent's configuration file parsi

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix assorted bugs in contrib/unaccent's configuration file parsi
Date: 2011-11-07 16:50:34
Message-ID: E1RNSP4-0006yq-Gz@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix assorted bugs in contrib/unaccent's configuration file parsing.

Make it use t_isspace() to identify whitespace, rather than relying on
sscanf which is known to get it wrong on some platform/locale combinations.
Get rid of fixed-size buffers. Make it actually continue to parse the file
after ignoring a line with untranslatable characters, as was obviously
intended.

The first of these issues is per gripe from J Smith, though not exactly
either of his proposed patches.

Branch
------
REL9_1_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/27864da6b1cf9fb3f29dc5abe1eba333cbc4ba77

Modified Files
--------------
contrib/unaccent/unaccent.c | 88 +++++++++++++++++++++++++++++++++----------
1 files changed, 68 insertions(+), 20 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2011-11-07 17:27:48 pgsql: Minor grammar improvements.
Previous Message Heikki Linnakangas 2011-11-07 15:44:21 pgsql: Fix timestamp range subdiff functions, when using float datetime