pgsql: Remove unnecessary AssertMacro() to suppress gcc 4.6 compiler wa

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Remove unnecessary AssertMacro() to suppress gcc 4.6 compiler wa
Date: 2011-10-18 21:39:57
Message-ID: E1RGHO9-0004xS-JZ@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove unnecessary AssertMacro() to suppress gcc 4.6 compiler warning.

There's no particular value in doing AssertMacro((tup) != NULL) in front
of code that's certain to crash anyway if tup is NULL. And if "tup" is
actually the address of a local variable, gcc 4.6 whinges about it. That's
arguably pretty broken on gcc's part, but we might as well remove the
useless test to silence the warnings. This gets rid of all the -Waddress
warnings in the backend; there are some in libpq and psql that are a bit
harder to avoid.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/7c19e0446c049dd41aed62fa398cd809017adf5e

Modified Files
--------------
src/include/access/htup.h | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2011-10-19 00:09:29 pgsql: Reject empty pg_hba.conf files.
Previous Message Tom Lane 2011-10-18 21:11:38 pgsql: Fix pg_dump to dump casts between auto-generated types.