pgsql: Don't mark auto-generated types as extension members.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Don't mark auto-generated types as extension members.
Date: 2011-10-12 22:42:10
Message-ID: E1RE7V4-0006Uo-Sw@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Don't mark auto-generated types as extension members.

Relation rowtypes and automatically-generated array types do not need to
have their own extension membership dependency entries. If we create such
then it becomes more difficult to remove items from an extension, and it's
also harder for an extension upgrade script to make sure it duplicates the
dependencies created by the extension's regular installation script.

I changed the code in such a way that this happened in commit
988cccc620dd8c16d77f88ede167b22056176324, I think because of worries about
the shell-type-replacement case; but that cure was worse than the disease.
It would only matter if one extension created a shell type that was
replaced with an auto-generated type in another extension, which seems
pretty far-fetched. Better to make this work unsurprisingly in normal
cases.

Report and patch by Robert Haas, comment adjustments by me.

Branch
------
REL9_1_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/e1e1b52c051fb2d554875455629d5ed20537dd62

Modified Files
--------------
src/backend/catalog/pg_type.c | 14 +++++++++-----
1 files changed, 9 insertions(+), 5 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2011-10-13 12:28:40 Re: pgsql: Document how to accent Alvaro Herrera in the release notes.
Previous Message Bruce Momjian 2011-10-12 21:20:44 pgsql: Document how to accent Alvaro Herrera in the release notes.