pgsql: Fix typo in pg_srand48 (srand48 in older branches).

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix typo in pg_srand48 (srand48 in older branches).
Date: 2011-09-03 20:18:27
Message-ID: E1Qzwfb-0006C9-Ql@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix typo in pg_srand48 (srand48 in older branches).

">" should be ">>". This typo results in failure to use all of the bits
of the provided seed.

This might rise to the level of a security bug if we were relying on
srand48 for any security-critical purposes, but we are not --- in fact,
it's not used at all unless the platform lacks srandom(), which is
improbable. Even on such a platform the exposure seems minimal.

Reported privately by Andres Freund.

Branch
------
REL9_1_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/b6cfede8b630db61afa7dd158adde93ba669f429

Modified Files
--------------
src/port/erand48.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2011-09-03 20:18:28 pgsql: Fix typo in pg_srand48 (srand48 in older branches).
Previous Message Tom Lane 2011-09-03 19:36:44 pgsql: Rearrange planner to save the whole PlannerInfo (subroot) for a