pgsql: Avoid creating PlaceHolderVars immediately within PlaceHolderVar

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Avoid creating PlaceHolderVars immediately within PlaceHolderVar
Date: 2011-08-09 15:34:28
Message-ID: E1QqoK4-0000gr-0Y@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Avoid creating PlaceHolderVars immediately within PlaceHolderVars.

Such a construction is useless since the lower PlaceHolderVar is already
nullable; no need to make it more so. Noted while pursuing bug #6154.

This is just a minor planner efficiency improvement, since the final plan
will come out the same anyway after PHVs are flattened. So not worth the
risk of back-patching.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/cff60f2dfa470d5736a19d36eb910844e31db764

Modified Files
--------------
src/backend/optimizer/prep/prepjointree.c | 20 ++++++++++++++++----
1 files changed, 16 insertions(+), 4 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2011-08-09 19:31:07 pgsql: Documentation improvement and minor code cleanups for the latch
Previous Message Peter Eisentraut 2011-08-09 15:31:47 pgsql: Use clearer notation for getnameinfo() return handling