pgsql: Clean up ill-advised attempt to invent a private set of Node tag

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Clean up ill-advised attempt to invent a private set of Node tag
Date: 2011-08-06 18:54:22
Message-ID: E1Qpm0s-00082J-Dr@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Clean up ill-advised attempt to invent a private set of Node tags.

Somebody thought it'd be cute to invent a set of Node tag numbers that were
defined independently of, and indeed conflicting with, the main tag-number
list. While this accidentally failed to fail so far, it would certainly
lead to trouble as soon as anyone wanted to, say, apply copyObject to these
node types. Clang was already complaining about the use of makeNode on
these tags, and I think quite rightly so. Fix by pushing these node
definitions into the mainstream, including putting replnodes.h where it
belongs.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/05e83968929f4ec1eba058fcae755fd2df98864e

Modified Files
--------------
src/backend/replication/repl_gram.y | 4 +-
src/backend/replication/walsender.c | 6 ++--
src/include/nodes/nodes.h | 7 ++++
src/include/nodes/replnodes.h | 52 ++++++++++++++++++++++++++++
src/include/replication/basebackup.h | 4 +-
src/include/replication/replnodes.h | 62 ----------------------------------
6 files changed, 66 insertions(+), 69 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message User Itagaki 2011-08-07 04:20:23 reorg - pg_reorg: version 1.1.7.
Previous Message Tom Lane 2011-08-06 01:18:42 pgsql: Fix thinko in documentation of local_preload_libraries.