pgsql: The rolled-back flag on serializable xacts was pointless and red

From: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: The rolled-back flag on serializable xacts was pointless and red
Date: 2011-06-15 10:41:48
Message-ID: E1QWnXg-0003JV-KX@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

The rolled-back flag on serializable xacts was pointless and redundant with
the marked-for-death flag. It was only set for a fleeting moment while a
transaction was being cleaned up at rollback. All the places that checked
for the rolled-back flag should also check the marked-for-death flag, as
both flags mean that the transaction will roll back. I also renamed the
marked-for-death into "doomed", which is a lot shorter name.

Branch
------
REL9_1_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/2b44a2d62d12406da59fa6b23a0854d1d5068b17

Modified Files
--------------
src/backend/storage/lmgr/predicate.c | 52 +++++++++++++---------------
src/include/storage/predicate_internals.h | 11 +++---
2 files changed, 29 insertions(+), 34 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message User Fxjr 2011-06-15 16:23:18 npgsql - Npgsql2: Fixed problem with last update about Password as
Previous Message Heikki Linnakangas 2011-06-15 09:15:58 pgsql: Make non-MVCC snapshots exempt from predicate locking. Scans wit