pgsql: Make citext's equality and hashing functions collation-insensiti

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Make citext's equality and hashing functions collation-insensiti
Date: 2011-06-08 19:25:17
Message-ID: E1QUONR-0006Ii-GD@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Make citext's equality and hashing functions collation-insensitive.

This is an ugly hack to get around the fact that significant parts of the
core backend assume they don't need to worry about passing collation to
equality and hashing functions. That's true for the core string datatypes,
but citext should ideally have equality behavior that depends on the
specified collation's LC_CTYPE. However, there's no chance of fixing the
core before 9.2, so we'll have to live with this compromise arrangement for
now. Per bug #6053 from Regina Obe.

The code changes in this commit should be reverted in full once the core
code is up to speed, but be careful about reverting the docs changes:
I fixed a number of obsolete statements while at it.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/3ebc061c18fcf9447977d232280793e27baf71ff

Modified Files
--------------
contrib/citext/citext.c | 23 ++++++++++++++------
doc/src/sgml/citext.sgml | 50 +++++++++++++++++++++++++++++++++------------
2 files changed, 52 insertions(+), 21 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2011-06-09 04:45:07 pgsql: Fix documentation of information_schema.element_types
Previous Message Peter Eisentraut 2011-06-08 17:54:41 pgsql: Reorder pg_ctl promote after pg_ctl status