From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Complain if pg_hba.conf contains "hostssl" but SSL is disabled. |
Date: | 2011-04-26 19:40:36 |
Message-ID: | E1QEo7g-0005GG-Eg@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Complain if pg_hba.conf contains "hostssl" but SSL is disabled.
Most commenters agreed that this is more friendly than silently failing
to match the line during actual connection attempts. Also, this will
prevent corner cases that might arise when trying to handle such a line
when the SSL code isn't turned on. An example is that specifying
clientcert=1 in such a line would formerly result in a completely
misleading complaint that root.crt wasn't present, as seen in a recent
report from Marc-Andre Laverdiere. While we could have instead fixed
that specific behavior, it seems likely that we'd have a continuing stream
of such bizarre behaviors if we keep on allowing hostssl lines when SSL is
disabled.
Back-patch to 8.4, where clientcert was introduced. Earlier versions don't
have this specific issue, and the code is enough different to make this
patch not applicable without more work than it seems worth.
Branch
------
REL8_4_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/64e258f8d71374dd9416ca75262a7b65f4a789b2
Modified Files
--------------
src/backend/libpq/hba.c | 15 ++++++++++++++-
1 files changed, 14 insertions(+), 1 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2011-04-26 19:56:50 | pgsql: Rephrase some not-supported error messages in pg_hba.conf proces |
Previous Message | Tom Lane | 2011-04-26 18:28:10 | Re: pgsql: Clarify that a non-specified precision NUMERIC has a very high r |