From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Improve findoidjoins to cover more cases. |
Date: | 2011-04-23 23:33:34 |
Message-ID: | E1QDmKU-000835-26@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Improve findoidjoins to cover more cases.
Teach the program and script to deal with OID-array referencing columns,
which we now have several of. Also, modify the recommended usage process
to specify that the program should be run against the regression database
rather than template1. This lets it find numerous joins that cannot be
found in template1 because the relevant catalogs are entirely empty.
Together these changes add seventeen formerly-missed cases to the oidjoins
regression test.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/795c382e8caf27f9db2fb09d12384b8183280fee
Modified Files
--------------
src/test/regress/expected/oidjoins.out | 136 ++++++++++++++++++++++++++++
src/test/regress/sql/oidjoins.sql | 68 ++++++++++++++
src/tools/findoidjoins/README | 57 ++++++++----
src/tools/findoidjoins/findoidjoins.c | 95 +++++++++++++++++---
src/tools/findoidjoins/make_oidjoins_check | 22 ++++--
5 files changed, 342 insertions(+), 36 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2011-04-24 00:28:30 | pgsql: In pg_upgrade, only compile copy_file() on non-Win32 systems. |
Previous Message | Andrew Dunstan | 2011-04-23 22:15:26 | pgsql: Silence a few compiler warnings from gcc on MinGW. |