pgsql: Make a code-cleanup pass over the collations patch.

Make a code-cleanup pass over the collations patch.

This patch is almost entirely cosmetic --- mostly cleaning up a lot of
neglected comments, and fixing code layout problems in places where the
patch made lines too long and then pgindent did weird things with that.
I did find a bug-of-omission in equalTupleDescs().

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/9e9b9ac7d1860fbb98eb4db17a94ff25524b6447

Modified Files
--------------
doc/src/sgml/catalogs.sgml | 8 ++--
doc/src/sgml/indices.sgml | 27 ++++++--------
doc/src/sgml/ref/create_collation.sgml | 7 ++--
doc/src/sgml/ref/create_domain.sgml | 2 +-
doc/src/sgml/ref/create_index.sgml | 12 +++++--
doc/src/sgml/ref/create_type.sgml | 4 +-
doc/src/sgml/regress.sgml | 6 ++--
src/backend/access/common/tupdesc.c | 6 +++-
src/backend/catalog/dependency.c | 4 ++-
src/backend/catalog/heap.c | 10 +++--
src/backend/catalog/index.c | 14 ++++---
src/backend/catalog/pg_type.c | 5 ++-
src/backend/commands/indexcmds.c | 6 ++-
src/backend/commands/tablecmds.c | 38 +++++++++++++++-----
src/backend/commands/typecmds.c | 10 +++---
src/backend/executor/nodeMergejoin.c | 8 ++--
src/backend/optimizer/plan/createplan.c | 57 +++++++++++++++++++-----------
src/backend/optimizer/plan/subselect.c | 11 ++++--
src/backend/parser/analyze.c | 10 +++--
src/backend/parser/parse_cte.c | 18 +++++-----
src/backend/parser/parse_relation.c | 8 +++--
src/backend/parser/parse_target.c | 13 ++++---
src/backend/utils/adt/ruleutils.c | 9 +++--
src/backend/utils/cache/syscache.c | 4 +-
24 files changed, 179 insertions(+), 118 deletions(-)