pgsql: Refrain from canonicalizing a client_encoding setting of "UNICOD

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Refrain from canonicalizing a client_encoding setting of "UNICOD
Date: 2011-04-19 16:25:53
Message-ID: E1QCDkP-0007YE-P4@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Refrain from canonicalizing a client_encoding setting of "UNICODE".

While "UTF8" is the correct name for this encoding, existing JDBC drivers
expect that if they send "UNICODE" it will read back the same way; they
fail with an opaque "Protocol error" complaint if not. This will be fixed
in the 9.1 drivers, but until older drivers are no longer in use in the
wild, we'd better leave "UNICODE" alone. Continue to canonicalize all
other inputs. Per report from Steve Singer and subsequent discussion.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/390cf3209b718382c0ec9793b714422189e9b68b

Modified Files
--------------
src/backend/commands/variable.c | 30 ++++++++++++++++++++++++------
1 files changed, 24 insertions(+), 6 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2011-04-19 17:20:55 pgsql: Avoid unused variable warnings for certain configurations
Previous Message Andrew Dunstan 2011-04-19 15:21:15 pgsql: Silence compiler warning about casting HANDLE to long on WIN64.